fix(navBar): update inkbar on screen resize #11042

chmelevskij · 2017-12-31T23:12:18Z

Changed how inkbar is moved. Using transform to scale and translate the
inkbar. Also added debounced update to window resize.

Closes #10121

PR Checklist

Please check that your PR fulfills the following requirements:

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #10121 mdInkBar doesn't update on screen resize.

What is the new behavior?

Debounced update of the mdInkBar.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Splaktar

I just had some minor change requests and a note that this may end up being a breaking change for some apps. We'll see how the presubmit tests go once the code review comments are addressed. Hopefully no one is using those private classes...

src/components/navBar/navBar.scss

src/components/navBar/navBar.js

Splaktar · 2018-03-16T07:54:44Z

Oh and I apologize for taking so long to get to this review!

src/components/navBar/navBar.js

Splaktar · 2018-04-19T22:45:27Z

@chmelevskij I would like to get this presubmitted and merged in a release pretty soon. Do you think that you will be able to address the review feedback soon?

chmelevskij · 2018-04-21T13:34:16Z

Hi there, will do that tomorrow, and hopefully submit the changes by the end of this week/ beginning of the next.

Splaktar · 2018-04-21T18:05:42Z

Excellent, thank you!

chmelevskij · 2018-04-22T10:51:22Z

Pushed the changes from review. Should I squash the commits and make a new PR?

Splaktar · 2018-05-19T20:17:58Z

@chmelevskij thank you for making those updates. Please squash the commits and then force push them up to this same branch. That will update this PR. We shouldn't need to create a new PR.

Sorry for the delay, I just returned from a couple conferences.

Splaktar

Looks like you got all of the requested changes but one. Also can you please remove the changes to the package-lock.json?

src/components/navBar/navBar.js

Splaktar · 2018-06-19T08:44:04Z

It's possible that this could go into 1.1.10 which we plan to release soon. Can you please address the comments above?

Splaktar · 2019-05-30T18:32:00Z

@chmelevskij can you please do a quick rebase and force push to your branch? Thank you.

Changed how inkbar is moved. Using transform to scale and translate the inkbar. Also added debounced update to window resize. Closes angular#10121

Splaktar · 2019-09-30T23:15:38Z

src/components/navBar/navBar.js

      '</div>',
    link: function(scope, element, attrs, ctrl) {
+
+      ctrl.width = $window.innerWidth;


Based on the test and lint failures, it appears that $window needs to be injected above into

function MdNavBar($mdAria, $mdTheming) {

Splaktar · 2019-09-30T23:16:07Z

src/components/navBar/navBar.js

+        angular.element($window).off('resize', onResize);
+      }
+
+      angular.element($window).on('resize', $mdUtil.debounce(onResize, 300));


It looks like $mdUtil needs to be injected too.

Splaktar · 2019-09-30T23:16:52Z

Thank you for rebasing, but there are some lint and build errors that need to be resolved now.

Splaktar · 2020-05-15T02:57:47Z

Fixed rebase/lint issues in PR #11912. Closing this one to continue the work there.

googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Dec 31, 2017

Splaktar added the needs: review This PR is waiting on review from the team label Jan 2, 2018

Splaktar added this to the 1.1.6 milestone Jan 2, 2018

Splaktar requested review from Splaktar and gmoothart January 2, 2018 19:36

Splaktar self-assigned this Jan 2, 2018

Splaktar added P2: required Issues that must be fixed. g3: reported The issue was reported by an internal or external product team. labels Jan 2, 2018

Splaktar modified the milestones: 1.1.6, 1.1.7 Jan 17, 2018

Splaktar modified the milestones: 1.1.7, 1.1.8 Feb 7, 2018

Splaktar suggested changes Mar 16, 2018

View reviewed changes

Splaktar removed the needs: review This PR is waiting on review from the team label Mar 16, 2018

Splaktar modified the milestones: 1.1.8, 1.1.9 Mar 16, 2018

Splaktar added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Mar 27, 2018

Splaktar removed the request for review from gmoothart April 19, 2018 22:40

Splaktar reviewed Apr 19, 2018

View reviewed changes

src/components/navBar/navBar.js Outdated Show resolved Hide resolved

Splaktar modified the milestones: 1.1.9, 1.1.10 Apr 19, 2018

Splaktar added the needs: squash commits label May 19, 2018

Splaktar suggested changes May 19, 2018

View reviewed changes

src/components/navBar/navBar.js Outdated Show resolved Hide resolved

Splaktar modified the milestones: 1.1.13, 1.1.14 Feb 10, 2019

Splaktar modified the milestones: 1.1.14, 1.1.15 Mar 14, 2019

Splaktar modified the milestones: 1.1.15, 1.1.16, 1.1.18, 1.1.19 Mar 29, 2019

Splaktar modified the milestones: 1.1.19, 1.1.20 May 30, 2019

Splaktar added the g3: sync label May 30, 2019

chmelevskij force-pushed the fix-nav-bar-ink branch from 240ba41 to d73d2bb Compare May 31, 2019 07:54

fix(NavBar): update inkbar on screen resize

a08b9cd

Changed how inkbar is moved. Using transform to scale and translate the inkbar. Also added debounced update to window resize. Closes angular#10121

chmelevskij force-pushed the fix-nav-bar-ink branch from d73d2bb to a08b9cd Compare May 31, 2019 16:29

Splaktar modified the milestones: 1.1.20, 1.1.21 Aug 15, 2019

Splaktar removed the needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved label Sep 30, 2019

Splaktar suggested changes Sep 30, 2019

View reviewed changes

Splaktar added in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs and removed pr: lgtm This PR has been approved by the reviewer labels Sep 30, 2019

Splaktar modified the milestones: 1.1.21, 1.1.22 Oct 22, 2019

Splaktar modified the milestones: 1.1.22, 1.1.23 Mar 6, 2020

Splaktar mentioned this pull request May 15, 2020

fix(navBar): update inkbar on screen resize #11912

Merged

3 tasks

Splaktar removed this from the 1.1.23 milestone May 15, 2020

Splaktar closed this May 15, 2020

fix(navBar): update inkbar on screen resize #11042

fix(navBar): update inkbar on screen resize #11042

Uh oh!

Conversation

chmelevskij commented Dec 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

Splaktar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Splaktar commented Mar 16, 2018

Uh oh!

Uh oh!

Splaktar commented Apr 19, 2018

Uh oh!

chmelevskij commented Apr 21, 2018

Uh oh!

Splaktar commented Apr 21, 2018

Uh oh!

chmelevskij commented Apr 22, 2018

Uh oh!

Splaktar commented May 19, 2018

Uh oh!

Splaktar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Splaktar commented Jun 19, 2018

Uh oh!

Splaktar commented May 30, 2019

Uh oh!

Splaktar Sep 30, 2019

Choose a reason for hiding this comment

Uh oh!

Splaktar Sep 30, 2019

Choose a reason for hiding this comment

Uh oh!

Splaktar commented Sep 30, 2019

Uh oh!

Splaktar commented May 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chmelevskij commented Dec 31, 2017 •

edited

Loading